more stringent test for CPUOffloadOptimizer #1650
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems with CPUOffloadOptimizer's synchronization (cf. #1649) are not detected by the current test case, as it is very benign, giving ample opportunity for transfers to complete even without explicit sync.
These changes try to make the situation a bit more challenging, decreasing the arithmetic density of the model and ensuring that the critical path is as short as possible.
This PR is deliberately not based on top of #1649, to show that this new test actually catches the synchronization problem. After that PR is merged, tests should pass again.