Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slight tolerance term in _check_hypercube #2679

Closed
wants to merge 1 commit into from
Closed

Add slight tolerance term in _check_hypercube #2679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion botorch/models/kernels/orthogonal_additive_kernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,8 @@ def _check_hypercube(x: Tensor, name: str) -> None:
x: Tensor to be checked.
name: Name of the Tensor for the error message.
"""
if (x < 0).any() or (x > 1).any():
tolerance = 1e-6
if (x < -1 * tolerance).any() or (x > 1 + tolerance).any():
raise ValueError(name + " is not in hypercube [0, 1]^d.")


Expand Down
Loading