Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix torch.load() in model_utils.py #696

Closed
wants to merge 1 commit into from
Closed

Fix torch.load() in model_utils.py #696

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion opacus/utils/module_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@ def clone_module(module: nn.Module) -> nn.Module:
"""
Handy utility to clone an nn.Module. PyTorch doesn't always support copy.deepcopy(), so it is
just easier to serialize the model to a BytesIO and read it from there.
When ``weights_only=False``, ``torch.load()`` uses "pickle" module implicity, which is known to be insecure.
Only load the model you trust.

Args:
module: The module to clone
Expand All @@ -99,7 +101,7 @@ def clone_module(module: nn.Module) -> nn.Module:
with io.BytesIO() as bytesio:
torch.save(module, bytesio)
bytesio.seek(0)
module_copy = torch.load(bytesio)
module_copy = torch.load(bytesio, weights_only=False)
next_param = next(
module.parameters(), None
) # Eg, InstanceNorm with affine=False has no params
Expand Down
Loading