Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Add tests for Tree #2738

Open
wants to merge 1 commit into
base: gh/kurtamohler/3/base
Choose a base branch
from

Conversation

kurtamohler
Copy link
Collaborator

@kurtamohler kurtamohler commented Jan 31, 2025

Stack from ghstack (oldest at bottom):

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jan 31, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2738

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 8 Unrelated Failures

As of commit 9a9272b with merge base dbc8e2e (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

kurtamohler added a commit that referenced this pull request Jan 31, 2025
ghstack-source-id: 8f7aa07a4d36aa3664eaa19cc35bd66fb9e61c24
Pull Request resolved: #2738
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 31, 2025
@kurtamohler kurtamohler requested a review from vmoens January 31, 2025 23:42
@kurtamohler
Copy link
Collaborator Author

I mostly wrote this to become more familiar with Tree. Maybe we don't strictly need these tests since a lot of it is also tested in TestMCTSForest, but I figured it might be good to have some tests that are independent of the MCTSForest API. If you think we don't need this, I'm fine with just closing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants