-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: webtorrent output display not showing up on stream start. #28
Comments
I would like to work on this issue. |
Sure. Assigning this to you. |
@notafk-rajat Hi, I forgot to notice but the template files you did in the previous PR are visible in the repo. Please move them to .workflows folder in this PR. |
Okay I'll do it. |
Hey @qascade , So I was going through readme.md to setup yast on my local environment. I got stuck at step 6 for a while so I had to do But still I'm not able to anything after that. Also webtorrent-cli is not installing correctly |
|
Would you like to work on bringing support for windows before working on this?? It's an intermediate issue and will teach you file management using Go. We can create two separate issues for the support of WSL and Windows. |
Sure I would love to learn something new while trying to fix this issue. That is the main reason I want to do open-source, learn on the go! (no referring to golang). |
Also, I think it would be better to exclude the moving of template files to workflow from this issue. |
I asked someone else to move the templates, so you don't need to do that anymore. Anyways, thanks for your continued interest in my project. If you have any questions or blockers do let me know. |
@notafk-rajat As almost all of the support issues are resolved, you can start looking back into this issue. |
Ok, the only solution for you is to get linux environment. You try getting a VM. But if that is not feasible for you, I'm afraid you won't be able to contribute to yast. |
I tried VM once but it was kinda laggy that's why I switched over to WSL. I'll try VM again and let you know. But it'll take a while maybe the day after tomorrow cause I have exams going on. |
In the meantime can you explain the issue in a bit more detail? Like on starting the stream the output screen is not popping up? The media player window? |
Use webtorrent-cli separately and run the stream command by hardcoding magnet. You will see an output on screen but that is not happening when the same command is executed in golang. Basically we need to explicitly pipe the |
Hmm great explanation, but I'll need to dumb it down a little for myself now. Cause the words like 'hardcoding magnet' went above my head. I know about how there are magnet links to download torrents. |
Hardcoding means just explicitly copy pasting. Like putting exact values as parameters instead of variables. For example : Like putting values yourself in the code will be hardcoding but taking user input will not be considered hardcoding. |
See the code where WebTorrent CLI command is getting executed |
Hey @qascade, you can remove me from this issue. I don't think I'll be able to work on yast unless I dual boot my system with Linux. |
Make sure that webtorrent output gets redirected to prompt after stream starts as it gives visual assurance to users whether the download started or not.
The text was updated successfully, but these errors were encountered: