Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webtorrent output display not showing up on stream start. #28

Open
qascade opened this issue Aug 25, 2022 · 20 comments
Open

fix: webtorrent output display not showing up on stream start. #28

qascade opened this issue Aug 25, 2022 · 20 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed yast/api

Comments

@qascade
Copy link
Owner

qascade commented Aug 25, 2022

Make sure that webtorrent output gets redirected to prompt after stream starts as it gives visual assurance to users whether the download started or not.

@qascade qascade added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers yast/api labels Aug 25, 2022
@qascade qascade added hacktoberfest bug Something isn't working labels Sep 28, 2022
@git-pixel22
Copy link
Contributor

I would like to work on this issue.

@qascade
Copy link
Owner Author

qascade commented Oct 3, 2022

Sure. Assigning this to you.

@qascade
Copy link
Owner Author

qascade commented Oct 4, 2022

@notafk-rajat Hi, I forgot to notice but the template files you did in the previous PR are visible in the repo. Please move them to .workflows folder in this PR.

@git-pixel22
Copy link
Contributor

Okay I'll do it.

@git-pixel22
Copy link
Contributor

git-pixel22 commented Oct 4, 2022

Hey @qascade , So I was going through readme.md to setup yast on my local environment. I got stuck at step 6 for a while so I had to do go run main.go to run the program. So we might need to check into that too.

But still I'm not able to anything after that. .yast/setup is not working

Screenshot 2022-10-04 233759

Also webtorrent-cli is not installing correctly

image

@qascade
Copy link
Owner Author

qascade commented Oct 4, 2022

yast does not support windows for now. That's why you are unable to set up its config files. I would need to install a linux environment. yast has also not been tested on wsl.

@qascade
Copy link
Owner Author

qascade commented Oct 4, 2022

Would you like to work on bringing support for windows before working on this?? It's an intermediate issue and will teach you file management using Go. We can create two separate issues for the support of WSL and Windows.

This was referenced Oct 4, 2022
@git-pixel22
Copy link
Contributor

Sure I would love to learn something new while trying to fix this issue. That is the main reason I want to do open-source, learn on the go! (no referring to golang).
I have WSL installed I'll try on it and let you know what I observe there.

@git-pixel22
Copy link
Contributor

Also, I think it would be better to exclude the moving of template files to workflow from this issue.

@qascade
Copy link
Owner Author

qascade commented Oct 4, 2022

I asked someone else to move the templates, so you don't need to do that anymore. Anyways, thanks for your continued interest in my project. If you have any questions or blockers do let me know.

@qascade
Copy link
Owner Author

qascade commented Oct 12, 2022

@notafk-rajat As almost all of the support issues are resolved, you can start looking back into this issue.

@git-pixel22
Copy link
Contributor

Well, I too have the same issue, I don't get the output on stream start (as I said previously in #51 and #53 ), because the WSL
and windows cannot support yast currently.

So I'm not sure what to do here.

@qascade
Copy link
Owner Author

qascade commented Oct 13, 2022

Ok, the only solution for you is to get linux environment. You try getting a VM. But if that is not feasible for you, I'm afraid you won't be able to contribute to yast.

@git-pixel22
Copy link
Contributor

I tried VM once but it was kinda laggy that's why I switched over to WSL. I'll try VM again and let you know. But it'll take a while maybe the day after tomorrow cause I have exams going on.

@git-pixel22
Copy link
Contributor

In the meantime can you explain the issue in a bit more detail? Like on starting the stream the output screen is not popping up? The media player window?

@qascade
Copy link
Owner Author

qascade commented Oct 13, 2022

Use webtorrent-cli separately and run the stream command by hardcoding magnet. You will see an output on screen but that is not happening when the same command is executed in golang. Basically we need to explicitly pipe the cmd go-routine's output to os.stdout

@git-pixel22
Copy link
Contributor

Hmm great explanation, but I'll need to dumb it down a little for myself now. Cause the words like 'hardcoding magnet' went above my head. I know about how there are magnet links to download torrents.

@qascade
Copy link
Owner Author

qascade commented Oct 13, 2022

Hardcoding means just explicitly copy pasting. Like putting exact values as parameters instead of variables.

For example :
You want to do
a = 5
print(a) // value not hard-coded
print(5) // value hard-coded.

Like putting values yourself in the code will be hardcoding but taking user input will not be considered hardcoding.

@qascade
Copy link
Owner Author

qascade commented Oct 13, 2022

See the code where WebTorrent CLI command is getting executed
. The function name is StartStream() if I remember correctly.

@git-pixel22
Copy link
Contributor

Hey @qascade, you can remove me from this issue. I don't think I'll be able to work on yast unless I dual boot my system with Linux.

@qascade qascade changed the title Webtorrent output display not showing up on stream start. fix: webtorrent output display not showing up on stream start. May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed yast/api
Projects
None yet
Development

No branches or pull requests

2 participants