Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows support to yast #53

Closed
qascade opened this issue Oct 4, 2022 · 7 comments · Fixed by #64
Closed

Add Windows support to yast #53

qascade opened this issue Oct 4, 2022 · 7 comments · Fixed by #64
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request hacktoberfest yast/cmd yast/config yast/docs yast/tui

Comments

@qascade
Copy link
Owner

qascade commented Oct 4, 2022

Description

As the config utilities were developed keeping Unix FileSystem in mind. We need to add support for creating config files of yast in the Windows File System. This issue was brought to the notice by @notafk-rajat in #28.

Hey @qascade , So I was going through readme.md to setup yast on my local environment. I got stuck at step 6 for a while so I had to do go run main.go to run the program. So we might need to check into that too.

But still I'm not able to anything after that. .yast/setup is not working

Screenshot 2022-10-04 233759

Also webtorrent-cli is not installing correctly

image

How are you planning to resolve on this issue?

First I would check which operating system, I am currently running yast on. Then accordingly I will choose a path for YAST_WORKDIR defined in utils/constants.go. Then, make changes to config functions.

Acceptance Criteria

  1. No behavioral changes should be observed while running yast on environments other than windows.
  2. yast should show the same behavior as other environments on windows.
  3. TUI should behave almost identically to its behavior in Unix environments, If this is not possible, we have to find alternatives or fallback accordingly.

Are you raising this issue under hacktoberfest?

Yes, I'm raising this issue under hacktoberfest 2022. This is a issue for experienced developer. You need experience of working with different environments. Have understanding of how all modules of yast work internally and have knowledge of both Unix and
Windows File System APIs and how to work with both of them in Go.

@qascade qascade changed the title Adding Windows support to yast Add Windows support to yast Oct 4, 2022
@qascade qascade added documentation Improvements or additions to documentation enhancement New feature or request yast/tui yast/cmd yast/docs yast/config hacktoberfest labels Oct 4, 2022
@git-pixel22
Copy link
Contributor

When you say Unix based, do you mean MacOS? Did you create yast on MacOS?

@qascade
Copy link
Owner Author

qascade commented Oct 4, 2022

Yes, I developed yast on macOS. As to Unix based means Unix literally.

@git-pixel22
Copy link
Contributor

git-pixel22 commented Oct 11, 2022

Things I have figured out

  1. Have to use go build rather than go build ./...`.
  2. Cannot use cmd for yast as it throws an error on running any yast command like ./yast --help throws '.' is not recognized as an internal or external command, operable program, or batch file.
  3. Use PowerShell instead.

Also, there is not output showing here as well. I have selected VLC as my default player. Maybe it's a problem on my end,, I'll look into it soon.

@qascade
Copy link
Owner Author

qascade commented Oct 11, 2022

I dont think it's gonna work in windows as we have not configured yast config file creation as per windows file system. I have described the issue in detail above.

@qascade
Copy link
Owner Author

qascade commented Oct 12, 2022

As mentioned in #51 , we were not able to successfully setup yast in wsl. So, for windows, we will provide a docker support. This will solve support problems in other platforms as well.

@qascade
Copy link
Owner Author

qascade commented Oct 12, 2022

@notafk-rajat Can you add a support.md in docs directory and document all our discussions in there. I will be closing this issue after updating the support.md and will create a separate issue for docker support.

@qascade
Copy link
Owner Author

qascade commented Oct 12, 2022

Will track docker image creation in #58.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request hacktoberfest yast/cmd yast/config yast/docs yast/tui
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants