Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support file in docs #61

Closed
wants to merge 2 commits into from
Closed

Added support file in docs #61

wants to merge 2 commits into from

Conversation

git-pixel22
Copy link
Contributor

Description -
The support file includes the challenges faced in windows and wsl support, and what solution we will be working on now.

Closes - #53

Copy link
Owner

@qascade qascade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the sentences should be other way around. yast does not support windows not that windows does not support yast, what would they get by supporting us anyway😂

docs/support.md Outdated
@@ -0,0 +1,12 @@
## Currently Windows and WSL2 do not support `yast`.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yast does not support windows and wsl2.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to mention, whenever working on docs keep the punctuation and the styles you use consistent. Non-consistent docs show unprofessional behavior. This will significantly decrease your time when working in non-code PRs

@@ -0,0 +1,12 @@
## Currently Windows and WSL2 do not support `yast`.

## Issue with Windows support
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.FileSystem -> File System
2.the config files of yast had no support in the Windows File System. -> the config utils will not exibit same behaviour of Windows File System

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks fine now, please check.

@git-pixel22
Copy link
Contributor Author

I think the sentences should be other way around. yast does not support windows not that windows does not support yast, what would they get by supporting us anyway😂

Well, I was thinking the same, but went with the way things were written in issues. 😂
I'll fix it asap.

@git-pixel22 git-pixel22 requested a review from qascade October 13, 2022 19:11
@git-pixel22
Copy link
Contributor Author

I'll just close these faulty PRs and make new fresh ones. Since my branches are not showing anymore locally. I have tried git fetch but not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants