-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to stable2412 #417
Conversation
peterwht
commented
Jan 3, 2025
•
edited
Loading
edited
- 2407 chore: upgrade to stable2407 #234
- 2409 https://github.com/r0gue-io/pop-node/pulls?q=is%3Apr+is%3Aclosed
- 2412 chore: uplift to polkadot 2412 #425
Co-authored-by: Daanvdplas <[email protected]> Co-authored-by: Daan van der Plas <[email protected]>
Not important but when uplifting the Newer versions remove this check so we should use |
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #417 +/- ##
==========================================
- Coverage 71.41% 71.28% -0.14%
==========================================
Files 72 72
Lines 13568 13626 +58
Branches 13568 13626 +58
==========================================
+ Hits 9690 9713 +23
- Misses 3605 3646 +41
+ Partials 273 267 -6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Things like default weight usage can, and should, be addressed outside of this PR with the changes coming with the mainnet runtime review: