Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove destroy witness #445

Open
wants to merge 11 commits into
base: chungquantin/feat-main_pallet_nonfungibles
Choose a base branch
from

Conversation

chungquantin
Copy link
Collaborator

Remove the witness data required as parameter from destroy() dispatchable function of nonfungibles pallet.

  • Pros: Improve developer experience.
  • Cons: Pre-dispatch weight charged up to u32::MAX.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (chungquantin/feat-main_pallet_nonfungibles@bd14977). Learn more about missing BASE report.

@@                              Coverage Diff                              @@
##             chungquantin/feat-main_pallet_nonfungibles     #445   +/-   ##
=============================================================================
  Coverage                                              ?   73.81%           
=============================================================================
  Files                                                 ?       77           
  Lines                                                 ?    15019           
  Branches                                              ?    15019           
=============================================================================
  Hits                                                  ?    11087           
  Misses                                                ?     3659           
  Partials                                              ?      273           
Files with missing lines Coverage Δ
pallets/api/src/nonfungibles/mod.rs 88.88% <100.00%> (ø)
pallets/api/src/nonfungibles/tests.rs 99.80% <100.00%> (ø)
runtime/devnet/src/config/api/mod.rs 90.97% <100.00%> (ø)

@chungquantin chungquantin force-pushed the chungquantin/feat-main_pallet_nonfungibles branch from df27276 to ea59ba3 Compare January 22, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants