Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3398 - FRA Reports - search and upload #3445
base: develop
Are you sure you want to change the base?
3398 - FRA Reports - search and upload #3445
Changes from 47 commits
bca4311
96b469b
c8ad478
7996526
7025dab
bfd1dc1
c6694b0
71e1e6e
8c36164
e25ca72
dedee58
e2eb9ac
902ca31
f2f42d6
dc4b650
ba40b4e
a8e4672
37f8a4a
691d413
9dfad44
16da0a2
556d89f
5254494
5816e4f
1d347f9
cd9f375
40e5f0a
b808d26
91ce6f3
72e90a5
97271f6
641f999
0b0be2f
16fc35d
6b3a133
84dd282
fe16f4e
c4eb8e4
b46b1f6
60998a7
e538493
0398d05
6862582
a71d996
d6db5ff
903134a
7f8d4b2
39e8488
2795258
cf82ab6
630cc1e
bedb71d
8d81d34
81c5130
247a477
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i accidentally changed the feature flag from
fra_access
tofra_reports
. just updated the help text here to be consistent, but it created a whole new migration. I named it0044
instead of the auto-generated0043
to avoid conflicts because #3440 created0043
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we stick this in a
finally
block just for safety? Looks likeonError
just returns null for the moment so it might not be necessary.This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file upload on FRA still expects standard datafiles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a form bug on this one too. Not sure if it was pre-existing or not. Upload a file that causes the file extension error seen above. Change search parameters, search, see that extension error is still rendered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried duplicating these on the TANF data files page and it seems to be allowing any file type to be uploaded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on the old data files page, we noticed that the extension errors are not being displayed. unsure exactly why, but it allows submission until the nginx file check catches it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed allowed extensions and the persistent error bug. good catches, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WRT the datafiles page, are we spinning off a new ticket for that?