-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3363 decommission kibana elasticsearch #3446
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3446 +/- ##
===========================================
+ Coverage 91.24% 91.62% +0.38%
===========================================
Files 303 300 -3
Lines 8734 8458 -276
Branches 650 636 -14
===========================================
- Hits 7969 7750 -219
+ Misses 645 591 -54
+ Partials 120 117 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@@ -11,7 +11,7 @@ | |||
schemas=[ | |||
RowSchema( | |||
record_type="M1", | |||
document=SSP_M1DataSubmissionDocument(), | |||
model=SSP_M1DataSubmissionDocument(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very confusing. I think the entire documents
directory in the search_indexes
app should be deleted. It doesn't make sense to have reference to documents since we no longer have Elastic. Why can't we just use the model directly like we were prior the elastic bulk create stuff? i.e. model=SSP_M1
where SSP_M1
is the django model in search_indexes.models.ssp
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, we can definitely do that now.
@@ -122,7 +122,7 @@ def run_preparsing_validators(self, line, generate_error): | |||
|
|||
def parse_line(self, line): | |||
"""Create a model for the line based on the schema.""" | |||
record = self.document.Django.model() if self.document is not None else dict() | |||
record = self.model.Django.model() if self.model is not None else dict() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you implement the suggestion below from m1.py
this line could be simply become: record = self.model()
.
Tested deployment in RAFT, everything works as normal. Need to decommission ES services in tf but this will be done once all the apps have decommissioned ES. |
Summary of Changes
Provide a brief summary of changes
Pull request closes #3363_
How to Test
NOTE: Tests are passing but have not tested deployment yet. Thought it makes sense to get an early review since this is such a big PR
Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
lfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):