Address Ruby 3.4 frozen string warnings and improve flaky test

rails · Jan 28, 2025 · d4d95ff · d4d95ff
1 parent e9661b0
commit d4d95ff
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/test/integration/processes_lifecycle_test.rb b/test/integration/processes_lifecycle_test.rb
@@ -121,7 +121,9 @@ class ProcessesLifecycleTest < ActiveSupport::TestCase
     no_pause = enqueue_store_result_job("no pause")
     pause = enqueue_store_result_job("pause", pause: SolidQueue.shutdown_timeout + 10.second)
 
-    signal_process(@pid, :TERM, wait: 0.5.second)
+    wait_while_with_timeout(1.second) { SolidQueue::ReadyExecution.count > 0 }
+
+    signal_process(@pid, :TERM, wait: 0.5)
 
     sleep(SolidQueue.shutdown_timeout + 0.5.second)
 

diff --git a/test/models/solid_queue/process_test.rb b/test/models/solid_queue/process_test.rb
@@ -60,7 +60,7 @@ class SolidQueue::ProcessTest < ActiveSupport::TestCase
     worker = SolidQueue::Worker.new(queues: "*", threads: 3, polling_interval: 0.2)
     hostname = "Basecamp’s-Computer"
 
-    Socket.stub :gethostname, hostname.force_encoding("ASCII-8BIT") do
+    Socket.stub :gethostname, hostname.dup.force_encoding("ASCII-8BIT") do
       worker.start
       wait_for_registered_processes(1, timeout: 1.second)