Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out bitvector.h to a submodule #4458

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

randombit
Copy link
Owner

The motivation here (and also #4456 #4457) is to reduce the size of utils which is a mandatory-to-compile module, in particular with a mind that even headers that are completely unused are compiled into the amalgamation source. With the meta-goal that with some work and luck it might be possible to reduce amalgamation-related miscompilations (#4454 #3097) to something small enough to make a viable bug report. But even if not, it reduces the size of the amalgamation for the common case (common for amalgamation that is) of a build with only selected modules enabled, since bitvector.h is only used for CMCE and that's a relatively niche algorithm.

Splitting bitvector.h to a submodule reduces the size of the minimized amalgamation (--amalgamation --mini) from 13480 lines to 12059 lines.

@coveralls
Copy link

Coverage Status

coverage: 91.266% (+0.002%) from 91.264%
when pulling 0514ca2 on jack/split-bitvector-to-submodule
into 2616446 on master.

Copy link
Collaborator

@reneme reneme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks. We had considered that in the context of the SuperH ICE as well.

@randombit randombit merged commit f6d1b76 into master Dec 3, 2024
38 checks passed
@randombit randombit deleted the jack/split-bitvector-to-submodule branch December 3, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants