Split out bitvector.h to a submodule #4458
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation here (and also #4456 #4457) is to reduce the size of
utils
which is a mandatory-to-compile module, in particular with a mind that even headers that are completely unused are compiled into the amalgamation source. With the meta-goal that with some work and luck it might be possible to reduce amalgamation-related miscompilations (#4454 #3097) to something small enough to make a viable bug report. But even if not, it reduces the size of the amalgamation for the common case (common for amalgamation that is) of a build with only selected modules enabled, sincebitvector.h
is only used for CMCE and that's a relatively niche algorithm.Splitting
bitvector.h
to a submodule reduces the size of the minimized amalgamation (--amalgamation --mini
) from 13480 lines to 12059 lines.