Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize whitespace #6238

Open
wants to merge 2 commits into
base: branch-25.02
Choose a base branch
from
Open

Normalize whitespace #6238

wants to merge 2 commits into from

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 20, 2025 •
edited
Loading

This PR applies pre-commit hooks to normalize whitespace (trimming trailing whitespace and enforcing consistent end-of-file newlines).

These rules are already applied to most other RAPIDS repos, so this PR aligns with the norm in RAPIDS.

@bdice bdice requested review from a team as code owners January 20, 2025 20:23
@bdice bdice requested review from AyodeAwe, cjnolet and vyasr January 20, 2025 20:23
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@bdice bdice self-assigned this Jan 20, 2025
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 20, 2025
vyasr
vyasr approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed the changes and they all look safe, so I'm approving assuming that all the failures are due to the upstream issues blocking cuml CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@vyasr vyasr vyasr approved these changes

@cjnolet cjnolet Awaiting requested review from cjnolet cjnolet is a code owner automatically assigned from rapidsai/cuml-cmake-codeowners

Assignees

@bdice bdice

Labels
ci CMake CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdice @vyasr @AyodeAwe