Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore cudf's __dataframe__ deprecation with simpler filters. #6239

Open
wants to merge 12 commits into
base: branch-25.02
Choose a base branch
from

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 21, 2025

This is a follow-up to #6229. That PR should unblock CI, but reviewers would like simpler filters.

See:

Copy link

copy-pr-bot bot commented Jan 21, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jan 21, 2025
@bdice bdice marked this pull request as ready for review January 21, 2025 22:07
@bdice bdice requested a review from a team as a code owner January 21, 2025 22:07
@bdice bdice requested review from cjnolet and csadorf January 21, 2025 22:07
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 21, 2025
@bdice bdice self-assigned this Jan 21, 2025
@betatim
Copy link
Member

betatim commented Jan 27, 2025

I updated this PR with the changes from #6227 which will, I think, fix the CI failures.

@bdice
Copy link
Contributor Author

bdice commented Jan 27, 2025

I removed a deprecation filter for a warning @csadorf and @jcrist said they could not reproduce. It occurred again in CI here. It happens in an optional job, perhaps there is a difference in the environment/dependencies/parameters/etc.

FAILED test_kneighbors_classifier.py::test_predict_non_gaussian[100-4-40-100] - FutureWarning: Support for loading dataframes via the `__dataframe__` interchange protocol is deprecated

https://github.com/rapidsai/cuml/actions/runs/12989973215/job/36226273552?pr=6239#step:8:5762

@betatim
Copy link
Member

betatim commented Jan 28, 2025

From the name of the CI job it sounds like it runs with cudf.pandas enabled, that might explain why locally they can't reproduce this. It looks like creating the cudf dataframes from cudf.pandas dataframes is what triggers the deprecation warning: X_device_train = cudf.DataFrame.from_pandas(X_host_train). Without the accelerator X_host_train is a pandas df, but with the accelerator it is a cudf.pandas df. My initial thought is that cudf.DataFrame.from_pandas needs updating to not use __dataframe__.

There is also a question for cudf.pandas dataframes: they should do what pandas does, either have a __dataframe__ without deprecation or not have it. At least it seems against its aim to behave differently from pandas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants