Revise the type reflection system #6241
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
csadorf
added
2 - In Progress
csadorf
commented
Jan 21, 2025
| # TODO: Replace CumlArrayDescriptor in cuml/common/array_descriptor.py | ||
|
|
||
|
|
||
| class CumlArrayDescriptor: |
There was a problem hiding this comment.
This will be moved into the array_descriptor module once the class is finalized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major revision to cuml's internal type reflection system.
This PR currently demonstrates revision of
LinearRegression,Ridge, andLogisticRegression.Closes #5022 .
Supersedes #6189 .
This PR is still in draft mode and not ready for detailed review or merge!
Currently labeled as
non-breakingwhile there are no breaking changes, however breaking changes are anticipated with this revision.Link to design doc