Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upper bound to prevent usage of numba 0.61.0 #6244

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Jan 22, 2025

Numba 0.61.0 just got released with a couple of breaking changes, this pr is required to unblock the ci.

xref: rapidsai/cudf#17777

@galipremsagar galipremsagar added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jan 22, 2025
Copy link

copy-pr-bot bot commented Jan 22, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added conda conda issue Cython / Python Cython or Python issue labels Jan 22, 2025
@galipremsagar galipremsagar marked this pull request as ready for review January 22, 2025 02:41
@galipremsagar galipremsagar requested a review from a team as a code owner January 22, 2025 02:41
@galipremsagar galipremsagar requested a review from bdice January 22, 2025 02:41
@galipremsagar
Copy link
Contributor Author

/okay to test

@dantegd
Copy link
Member

dantegd commented Jan 22, 2025

/merge

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jan 22, 2025
@galipremsagar
Copy link
Contributor Author

@dantegd The current failures seem to be unrelated to this PR, can we gett this PR admin merged?

@dantegd dantegd requested a review from a team as a code owner January 22, 2025 21:59
@dantegd dantegd requested a review from wphicks January 22, 2025 21:59
@galipremsagar
Copy link
Contributor Author

/merge

@bdice
Copy link
Contributor

bdice commented Jan 23, 2025

Tests failed with:

FAILED test_no_cuinit.py::test_cuml_create_estimator_cuinit - AssertionError: assert 127 == 0
 +  where 127 = CompletedProcess(args=['/usr/local/cuda/bin/cuda-gdb', '-x', '-', '--args', '/pyenv/versions/3.10.16/bin/python', '-c'...rror while loading shared libraries: libpython3.8.so.1.0: cannot open shared object file: No such file or directory\n').returncode
= 1 failed, 14405 passed, 6002 skipped, 648 xfailed, 68 xpassed, 848 warnings in 4243.73s (1:10:43) =

This is obviously super weird because we have a Python 3.10 job failing with a claim that it cannot find libpython3.8.so.1.0. I have seen this before and I don't have an explanation for it, but it usually goes away if you rerun the job. I'm going to try rerunning.

@rapids-bot rapids-bot bot merged commit bd7c69e into rapidsai:branch-25.02 Jan 23, 2025
65 checks passed
@bdice
Copy link
Contributor

bdice commented Jan 23, 2025

Rerunning seems to have worked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge conda conda issue Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants