Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor for dispatch style #21

Merged
merged 38 commits into from
Nov 13, 2024
Merged

refactor for dispatch style #21

merged 38 commits into from
Nov 13, 2024

Conversation

msarahan
Copy link
Contributor

@msarahan msarahan commented Nov 5, 2024

No description provided.

@msarahan msarahan force-pushed the telemetry-dispatch-actions branch 2 times, most recently from 3d498a2 to a8171ef Compare November 7, 2024 19:33
@msarahan msarahan force-pushed the telemetry-dispatch-actions branch from a27e23b to d2252e2 Compare November 8, 2024 16:31
@msarahan msarahan force-pushed the telemetry-dispatch-actions branch from 94315c1 to 64cd994 Compare November 8, 2024 18:03
@msarahan msarahan mentioned this pull request Nov 8, 2024
Merged
msarahan added 21 commits November 8, 2024 12:39
@msarahan
set default value for endpoint and protocol
6182306
@msarahan
set defaults for SHARED_ACTIONS env vars
961c10f
@msarahan
re-export when stashing so that defaults take effect
36c6347
@msarahan
move default shared actions repo to dispatch script
881a7f8
@msarahan
add default shared-actions repo and ref to last dispatch script
071b9bc
@msarahan
set default branch to telemetry-dispatch-actions in dispatch for now
043229c
@msarahan
rename base-env-vars to telemetry-env-vars for clarity of purpose
d9ff2b9
@msarahan
syntax in setting attributes
e638f91
@msarahan
semicolon all the things
31dbbe7
@msarahan
fix default protocol
a5f9e34
@msarahan
replace cat | jq with plain file reads
d85c7f9
@msarahan
trim leading comma from attributes
d64dd46
@msarahan
debugging output
eaa996d
@msarahan
shouldn't remove traceparent for job in summarize
a313c3f
@msarahan
parent span id for top-level traceparent
4a974d7
@msarahan
fix logic on top-level traceparent
8a83c40
@msarahan
add start time to root workflow
3f7ceee
@msarahan
trim leading comma from env vars when loading
8d7b889
@msarahan
use bash to remove leading commas
5cc031f
@msarahan
use bash to remove leading commas
0d8f149
@msarahan
give up on bash and use sed
4f01885
bdice
bdice reviewed Nov 12, 2024
View reviewed changes
telemetry-dispatch-write-summary/action.yml Outdated Show resolved Hide resolved
.github/workflows/test-child-workflow.yaml Outdated Show resolved Hide resolved
.github/workflows/test-telemetry-setup.yaml Outdated Show resolved Hide resolved
.github/workflows/test-telemetry-setup.yaml Outdated Show resolved Hide resolved
.github/workflows/test-telemetry-setup.yaml Outdated Show resolved Hide resolved
.github/workflows/test-telemetry-setup.yaml Outdated Show resolved Hide resolved
.github/workflows/test-telemetry-setup.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
telemetry-impls/github-actions-job-info/example-gha-job-log.json Outdated Show resolved Hide resolved
telemetry-impls/traceparent/full-run.json Outdated Show resolved Hide resolved
@msarahan msarahan merged commit 856caa9 into main Nov 13, 2024
@msarahan msarahan deleted the telemetry-dispatch-actions branch November 13, 2024 20:59
@msarahan msarahan restored the telemetry-dispatch-actions branch November 13, 2024 21:35
@msarahan msarahan deleted the telemetry-dispatch-actions branch December 17, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 left review comments

@bdice bdice bdice left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msarahan @bdice @ajschmidt8