avoid unnecessary wheel builds #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
This comment was marked as resolved.
This comment was marked as resolved.
|
/ok to test |
jameslamb
changed the title
msarahan
approved these changes
Dec 19, 2024
|
James is out for the holidays. I'm going to merge this so it doesn't sit for the 2 weeks or whatever. |
|
/merge |
|
thank you both!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #260.
Contributes to rapidsai/build-planning#33
Limits
libucxxwheel-building to just running once per combination of(CUDA version, CPU architecture)... cutting out 8 unnecessary CI jobs per commit.Notes for Reviewers
Why is this safe to do?
Unlike wheels that have Cython code,
libucxxwheels don't depend on the Python minor versionucxx/python/libucxx/pyproject.toml
Line 48 in ec860d9
e.g., they have tags like
Similar filters are being used for most C++ wheel builds across RAPIDS, e.g. https://github.com/rapidsai/cudf/blob/a95fbc88f94df24c3418766fbbea5b6633ff2328/.github/workflows/pr.yaml#L222-L230