[refactor][kubectl-plugin] require one posarg in session

command with Cobra's built-in `cobra.ExactArgs(1)` instead of writing our own logic. ## Before ```console $ kubectl ray session Error: session (RAYCLUSTER | TYPE/NAME) See 'ray session -h' for help and examples ``` ## After ```console $ kubectl ray session Error: accepts 1 arg(s), received 0 ``` Signed-off-by: David Xia <[email protected]>
ray-project · Feb 11, 2025 · 838854d · 838854d
1 parent 5cc2364
commit 838854d
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 9 deletions.
diff --git a/kubectl-plugin/pkg/cmd/session/session.go b/kubectl-plugin/pkg/cmd/session/session.go
@@ -87,6 +87,7 @@ func NewSessionCommand(streams genericiooptions.IOStreams) *cobra.Command {
 		Short:             "Forward local ports to the Ray resources.",
 		Long:              sessionLong,
 		Example:           sessionExample,
+		Args:              cobra.ExactArgs(1),
 		ValidArgsFunction: completion.RayClusterResourceNameCompletionFunc(factory),
 		RunE: func(cmd *cobra.Command, args []string) error {
 			if err := options.Complete(cmd, args); err != nil {
@@ -106,10 +107,6 @@ func NewSessionCommand(streams genericiooptions.IOStreams) *cobra.Command {
 }
 
 func (options *SessionOptions) Complete(cmd *cobra.Command, args []string) error {
-	if len(args) != 1 {
-		return cmdutil.UsageErrorf(cmd, "%s", cmd.Use)
-	}
-
 	typeAndName := strings.Split(args[0], "/")
 	if len(typeAndName) == 1 {
 		options.ResourceType = util.RayCluster

diff --git a/kubectl-plugin/pkg/cmd/session/session_test.go b/kubectl-plugin/pkg/cmd/session/session_test.go
@@ -67,11 +67,6 @@ func TestComplete(t *testing.T) {
 			expectedName:         "test-resource",
 			hasErr:               false,
 		},
-		{
-			name:   "invalid args (no args)",
-			args:   []string{},
-			hasErr: true,
-		},
 		{
 			name:   "invalid args (too many args)",
 			args:   []string{"raycluster/test-raycluster", "extra-arg"},