Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samples to use Ray 2.41.0 images #2964

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

andrewsykim
Copy link
Collaborator

Why are these changes needed?

Update samples to use 2.41

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@andrewsykim
Copy link
Collaborator Author

Fixes #2947

@@ -85,7 +85,7 @@ spec:
effect: "NoSchedule"
containers:
- name: ray-worker
image: rayproject/ray-ml:2.9.0-gpu
image: rayproject/ray-ml:2.41.0.021baf-py311
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, the worker Pod may use a different Python version than the head Pod.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, this was the only manifest I wasn't able to test cause my cluster didn't have GCSFuse enabled. Validated this works when I use rayproject/ray-ml:2.41.0.021baf-py39

@kevin85421 kevin85421 self-assigned this Feb 7, 2025
@kevin85421
Copy link
Member

@andrewsykim feel free to merge if it is ready

@kevin85421 kevin85421 merged commit b12a722 into ray-project:master Feb 7, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants