[feat][kubectl-plugin] list Ray nodes #3007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidxia
force-pushed
the
get-nodes
branch
2 times, most recently
from
f083cc9 to
d6c0fd5
Compare
davidxia
commented
Feb 11, 2025
andrewsykim
reviewed
Feb 12, 2025
davidxia
force-pushed
the
get-nodes
branch
4 times, most recently
from
a224f32 to
1405b6f
Compare
|
Overall LGTM, @chiayi can you take a look too please? |
davidxia
commented
Feb 12, 2025
andrewsykim
approved these changes
Feb 13, 2025
| memory resource.Quantity | ||
| namespace string | ||
| cluster string | ||
| _type string |
There was a problem hiding this comment.
why the underscore on this field?
There was a problem hiding this comment.
type is a reserved keyword in Go. Lmk if there's a better name or convention.
| @@ -0,0 +1,3 @@ | |||
| NAMESPACE NAME CPUS GPUS TPUS MEMORY CLUSTER WORKER GROUP AGE | |||
There was a problem hiding this comment.
What's the reason for this result not having type column?
| @@ -0,0 +1,2 @@ | |||
| NAMESPACE NAME CPUS GPUS TPUS MEMORY CLUSTER WORKER GROUP AGE | |||
| namespace-1 pod-1 1 1 1 1Gi cluster-1 group-1 60m | |||
There was a problem hiding this comment.
What's the reason for this result not having type column?
davidxia
commented
Feb 13, 2025
| return cmd | ||
| } | ||
|
|
||
| // joinLabelMap joins a map of K8s label key-val entries into a label selector string | ||
| func joinLabelMap(labelMap map[string]string) string { |
There was a problem hiding this comment.
moved here from get_workergroup.go since it's used by get_nodes.go now too
| memory resource.Quantity | ||
| namespace string | ||
| cluster string | ||
| _type string |
There was a problem hiding this comment.
type is a reserved keyword in Go. Lmk if there's a better name or convention.
|
Updated to not use test fixture files. I inlined the expected output based on this suggestion. |
with ```console kubectl ray (get|list) node[s] (NODE_NAME) \ [(-c/--ray-cluster) RAYCLUSTER] [(-n/--namespace) NAMESPACE] [(-A/--all-namespaces)] ``` ## Example Usage ```console $ kubectl ray get nodes -A NAMESPACE NAME CPUS GPUS TPUS MEMORY CLUSTER TYPE WORKER GROUP AGE explorer-guy whyme-gpuworker-worker-mqgmn 36 4 0 256Gi whyme worker gpuWorker 10d explorer-guy whyme-head-76l5c 8 0 0 16Gi whyme head headgroup 10d foundation-botox mrripvan-cpuworker-worker-lpkcs 16 0 0 64Gi mrripvan worker cpuWorker 6h6m foundation-botox mrripvan-gpuworker-worker-snkgp 16 2 0 128Gi mrripvan worker gpuWorker 6h6m foundation-botox mrripvan-head-swm6t 16 0 0 64Gi mrripvan head headgroup 6h6m $ kubectl ray get nodes -n foundation-botox NAME CPUS GPUS TPUS MEMORY CLUSTER TYPE WORKER GROUP AGE mrripvan-cpuworker-worker-lpkcs 16 0 0 64Gi mrripvan worker cpuWorker 6h6m mrripvan-gpuworker-worker-snkgp 16 2 0 128Gi mrripvan worker gpuWorker 6h6m mrripvan-head-swm6t 16 0 0 64Gi mrripvan head headgroup 6h6m $ kubectl ray get nodes -n foundation-models -c oyster-v3 NAME CPUS GPUS TPUS MEMORY CLUSTER TYPE WORKER GROUP AGE oyster-v3-cpuworker-worker-kvhz5 20 0 0 200Gi oyster-v3 worker cpuWorker 17d oyster-v3-gpuworker-worker-6s98f 200 8 0 1000Gi oyster-v3 worker gpuWorker 14d oyster-v3-head-cflmj 25 0 0 200Gi oyster-v3 head headgroup 17d oyster-v3-redis-worker-nh72b 1 0 0 12Gi oyster-v3 worker redis 17d $ kubectl ray get nodes -n foundation-models -c oyster-v3 oyster-v3-gpuworker-worker-6s98f NAME CPUS GPUS TPUS MEMORY CLUSTER TYPE WORKER GROUP AGE oyster-v3-gpuworker-worker-6s98f 200 8 0 1000Gi oyster-v3 worker gpuWorker 14d ``` Signed-off-by: David Xia <[email protected]>
andrewsykim
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with
This idea was originally described in this doc.
Checks