Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][CI] E2E tests do not reflect error #3021

Merged

Conversation

MortalHappiness
Copy link
Member

@MortalHappiness MortalHappiness commented Feb 11, 2025

Why are these changes needed?

https://buildkite.com/ray-project/ray-ecosystem-ci-kuberay-ci/builds/6857#0194f71f-8691-49cf-9279-cfc00c5e82fc

e2e tests failed but displayed success.

image

After this PR:

https://buildkite.com/ray-project/ray-ecosystem-ci-kuberay-ci/builds/6859#0194f740-3433-43ad-aaf1-f81de55661b5

image

Related issue number

N/A

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@MortalHappiness MortalHappiness changed the title Bugfix/e2e test no show error [Fix][CI] E2E tests do not reflect error Feb 11, 2025
@MortalHappiness MortalHappiness marked this pull request as draft February 11, 2025 22:56
@MortalHappiness MortalHappiness force-pushed the bugfix/e2e-test-no-show-error branch 2 times, most recently from b712f2f to 942c31b Compare February 11, 2025 23:17
@MortalHappiness MortalHappiness marked this pull request as ready for review February 11, 2025 23:17
@kevin85421 kevin85421 merged commit 9559227 into ray-project:master Feb 12, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants