Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid using aria-hidden on a focused element #451

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Aug 6, 2024

#449 类似,不过是在 antd 5.x 中修复,并移除一个多余的 div。

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dialog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 3:46pm

@@ -157,13 +156,12 @@ const Panel = React.forwardRef<ContentRef, PanelProps>((props, ref) => {
onMouseDown={onMouseDown}
onMouseUp={onMouseUp}
>
<div tabIndex={0} ref={sentinelStartRef} style={sentinelStyle} aria-hidden="true" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有了下面这个 div,第一个可以去掉了。

@afc163 afc163 merged commit 2580d29 into master Aug 9, 2024
9 checks passed
@afc163 afc163 deleted the fix/aria-hidden branch August 9, 2024 04:57
afc163 added a commit to ant-design/ant-design that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant