Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Mentions doesnt work on chrome and on firefox #280
fix: Mentions doesnt work on chrome and on firefox #280
Changes from 2 commits
ac6176e
99f27f8
d1255a7
2b013dc
d09fe09
713706b
32714f2
507362d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jarryxin Is this correct? Should #281 already resolve the problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可能确实不一样,我是用港版mac改成法语,测试alt是 18,在我修改的版本发邮件给提问者,他说是正确的。是否应该两种alt都兼容?
Maybe it's different. I changed from using the Hong Kong version of Mac to French, and the alt test was 18. In the revised version I provided to the questioner, he said it was correct. Should both alt versions be compatible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ant-design/ant-design#50795 (comment) in this comment , the alt keycode is 18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im azerty user we have 2 Alt keys the one u talked about and the other one it AltGr that it been user to do @ cus in azerty keyboard just normal Alt + à dosnt do anything AltGr does
I guess in mac in diffrent or something
In azert keyboard we have left alt whiche it all keyboard and the right AltGr with it only in azerty keyboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
U can merge both do if u wanna satay safe in case ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess we should merge both of them do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cus in ur coode u looking for the key number which it 18 OR 225 depending on keyboard but key name gonna stay the same which it AltGraph it dosnt change ... that's make using key=== "AltGraph" moore affection than using which key number but im fine with merging both of them if thats gonna suit u @yoyo837 @Jarryxin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KeyCode.ALT
orAltGraph
? Which one is correct?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep
KeyCode.ALT
?