fix: tagRender should not be called when value is empty

react-component · Jan 12, 2025 · 22a6831 · 22a6831
1 parent fa18f57
commit 22a6831
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/src/Selector/MultipleSelector.tsx b/src/Selector/MultipleSelector.tsx
@@ -188,6 +188,10 @@ const SelectSelector: React.FC<SelectorProps> = (props) => {
   };
 
   const renderRest = (omittedValues: DisplayValueType[]) => {
+    // https://github.com/ant-design/ant-design/issues/48930
+    if (!values.length) {
+      return null;
+    }
     const content =
       typeof maxTagPlaceholder === 'function'
         ? maxTagPlaceholder(omittedValues)

diff --git a/tests/Tags.test.tsx b/tests/Tags.test.tsx
@@ -323,6 +323,20 @@ describe('Select.Tags', () => {
       });
     });
 
+    // https://github.com/ant-design/ant-design/issues/48930
+    it('should not call tagRender when value is empty', () => {
+      const tagRender = jest.fn();
+      render(
+        <Select
+          mode="tags"
+          value={[]}
+          tagRender={tagRender}
+          options={[{ value: 'light' }, { value: 'dark' }]}
+        />,
+      );
+      expect(tagRender).not.toHaveBeenCalled();
+    });
+
     it('disabled', () => {
       const tagRender = jest.fn();
       render(