Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROD-2538]: Add pipeline for schema validation #8

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

harjotsinghgill
Copy link

@harjotsinghgill harjotsinghgill commented Feb 18, 2025

Description

This PR encapsulates the following work for PROD-2538

  • Create a script to validate JSON schemas against sample data
  • Generate sample data, valid, invalid and edge cases and store it in a file for each schema in the repo
  • Create a workflow file for github actions, triggering it on PR checks

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit Test
  • Integration Test
  • Manual Test
  • Others (specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@chun-ko
Copy link
Contributor

chun-ko commented Feb 18, 2025

@harjotsinghgill basic direction is correct, thanks for the hard work

Thing to do:

  • ensure all test is passed
  • break the dev and pr to 2 different workflow dev.yaml and pr.yaml, only includes compass in dev.yaml

@harjotsinghgill
Copy link
Author

@chun-ko The requested changes have been done. Please have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants