Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modules ACL support #3102

Merged
merged 8 commits into from
Jan 30, 2025
Merged

Add modules ACL support #3102

merged 8 commits into from
Jan 30, 2025

Conversation

sazzad16
Copy link
Contributor

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@sazzad16 sazzad16 changed the title Test HASH module ACL support Add modules ACL support Dec 26, 2024
@sazzad16 sazzad16 marked this pull request as ready for review January 23, 2025 17:40
@tishun
Copy link
Collaborator

tishun commented Jan 28, 2025

Perhaps this needs to wait for #3145 to get merged so the CI could pass?
We may need to address the matrix build too.

@ggivo
Copy link
Contributor

ggivo commented Jan 29, 2025

@sazzad16 @tishun
PR 3145 will not help in this case. 8.0 env is still bootstrapped by building it locally. When building locally with make Redis server 8.0 will not include modules. I think we can base those tests on io.lettuce.core.RedisContainerIntegrationTests which bring up test env from pre-build docker containers including modules

@tishun
Copy link
Collaborator

tishun commented Jan 29, 2025

Hey @sazzad16 can we also get the conflicts resolved?

@sazzad16
Copy link
Contributor Author

@tishun Done!

Copy link
Collaborator

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this!

@sazzad16 sazzad16 merged commit d76e39e into redis:main Jan 30, 2025
8 checks passed
@sazzad16 sazzad16 deleted the modules-acl branch January 30, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants