[Draft] [CAE-580] Migrate Lettuce test setup to use client-lib-test #3158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiryazovi-redis
force-pushed
the
topic/kiryazovi-redis/use-docker-for-tests
branch
from
24693f5 to
b9dceb8
Compare
kiryazovi-redis
force-pushed
the
topic/kiryazovi-redis/use-docker-for-tests
branch
from
1f6b443 to
c4e3b08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that:
mvn formatter:formattarget. Don’t submit any formatting related changes.Only tests that are failing are:
SSL issue where two redis containers must talk with eachother and migrate a key
[ERROR] RunOnlyOnceServerCommandIntegrationTests.migrate:83 » RedisCommandExecution IOERR error or timeout writing to target instance
[ERROR] RunOnlyOnceServerCommandIntegrationTests.migrateCopyReplace:99 » RedisCommandExecution IOERR error or timeout writing to target instance
Sentinel ssl issue, that must have connectivity between all containers involved and re-route to master.
[ERROR] MasterReplicaSentinelSslIntegrationTests.testMasterReplicaSentinelBasic:78 » RedisConnection Unable to connect to rediss-sentinel://localhost?verifyPeer=NONE&sentinelMasterId=mymaster
[ERROR] SentinelSslIntegrationTests.shouldConnectToMasterUsingSentinel:82 » RedisConnection Cannot connect to a Redis Sentinel: [rediss://localhost:26379]
That is the reason why this review is draft.
After the tests pass, will likely reduce redis.conf files in size as some of the config are provided by default.
Also, there is some small work left on the docker-compose.