feat: minimal resource states when creating and when read while deleting #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes Clusters, Serverless Clusters, and Networks to: - When creating, store their id in the Terraform state as soon as we have it. This way, if creation fails for any reason, Terraform knows that we have a tainted resource and it can be deleted, manually untainted, etc., and Terraform won't try to recreate it (which usually fails since the name is taken). - When reading, if the resource is in the process of being deleted, null out most of their Terraform state _aside from_ their id, so that Terraform knows they can't be used anymore and needs to destroy (i.e. wait for them to finish deleting) and recreate them to match the plan.
The Cloud API will accept a delete operation regardless of the current cluster state. This allows users to delete a partially-created cluster without having to wait for it to fully come up.
|
@gene-redpanda I noticed some of the recent tests are timing out on cluster creation, and then failing to clean up resources because Terraform doesn't know the clusters exist. I pulled this out of the BYOC work, this should help Terraform recover and delete the clusters and then rest of the resources correctly. |
gene-redpanda
approved these changes
Oct 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't wait for clusters to be in a ready state before deleting them. The Cloud API will accept a delete operation regardless of the current cluster state. This allows users to delete a partially-created cluster without having to wait for it to fully come up.
When creating Clusters, Serverless Clusters, and Networks, store their id in the Terraform state as soon as we have it. This way, if creation fails for any reason, Terraform knows that we have a tainted resource and it can be deleted, manually untainted, etc., and Terraform won't try to recreate it (which usually fails since the name is taken).
When reading Clusters, Serverless Clusters, and Networks, if the resource is in the process of being deleted, null out most of their Terraform state aside from their id, so that Terraform knows they can't be used anymore and needs to destroy (i.e. wait for them to finish deleting) and recreate them to match the plan.