[chore] remove TODOs and add cluster spec validators #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes TODOs that are now issues in GH and also add error checks when either the cluster type or cloud provider are invalid.
gene-redpanda
approved these changes
Jan 27, 2024
andrewstucki
pushed a commit
to andrewstucki/terraform-provider-redpanda
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes TODOs that are now issues in GH and also adds error checks when either the cluster type or cloud provider is invalid.
I tried sending requests to the control plane API and they fail if we don't specify a valid type/provider:
So we better fail early here.