Enable Publishing to Terraform Registry #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gene-redpanda
changed the title
gene-redpanda
changed the title
gene-redpanda
force-pushed
the
github-actions-and-publishing
branch
from
5a3d239 to
68f6a7d
Compare
r-vasquez
reviewed
Feb 7, 2024
Comment on lines
+1
to
+2
| # Visit https://golangci-lint.run/ for usage documentation | ||
| # and information on other useful linters |
There was a problem hiding this comment.
I think this a stray file and the golangci lint changed a lot after this. We can delete this one.
| flags: | ||
| - -trimpath | ||
| ldflags: | ||
| - '-s -w -X main.version={{.Version}} -X main.commit={{.Commit}}' |
There was a problem hiding this comment.
I don't see the main.commit in the main package, but I do see the version.
r-vasquez
approved these changes
Feb 7, 2024
andrewstucki
pushed a commit
to andrewstucki/terraform-provider-redpanda
that referenced
this pull request
Nov 22, 2024
* add outputs to support airgap I want to be able to build route53 records off of stateful ids and the "public" ip generated by a supplied vpc. Doing this with the current outputs results in issues when using random_id + count on the module's outputs. With this method we should be ok. * minor fix + test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much exactly follows the directions here: https://developer.hashicorp.com/terraform/registry/providers/publishing
Only differences are golangci remediation.