Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python version 3.7 with architecture x64 not found for Ubuntu 24.04 #27

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

slothkong
Copy link
Contributor

Hello @rfdearborn,
First of all, thanks for the awesome work you and your collaborators have done with this GitHub Action.

This PR addresses #26.
The issue is straight forward: Python 3.7 is not any more part of the GitHub runner image tagged as ubuntu-latest (see the image manifest). In fact, is not part of any of the available Ubuntu-base runner images anymore.

I bumped the Python version to 3.12, alongside versions of pre-required GitHub actions. I chose 3.12 as is the latest version for dbt supports (see compatibility matrix). This should cover dbt v1.7+ and dbt v1,8+, including the latest data unittest features.

I have verified that

  1. Changes I made do not break the project's tests (see workflow run details)
  2. The GitHub action runs end-to-end, using my own dbt project with a CI pipeline using slothkong/dbt-docs-to-notion@main, and my own Notion instance (see [1] and [2])

Let me know if there is anything else I can do to make it easier for the fix to get merged~

[1] Logs of dbt project's CI pipeline
image

[2] Output in Notion
image

@rfdearborn rfdearborn merged commit 220ebde into rfdearborn:main Feb 13, 2025
1 check passed
@rfdearborn
Copy link
Owner

Lgtm. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants