Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves upon #45 by enabling parallel processing only for the top-level call. Any nested calls use single-threaded. Time is now 22.2 ms so about a 7% improvement.
The problem with the old/current approach is that the
par_iter
starts but then is called another time below. Much better could be to gather all ops together and then callpar_iter
once. See https://fasterthanli.me/articles/recursive-iterators-rust and https://blog.danieljanus.pl/2023/07/20/iterating-trees/.I've tried an iterator like
but since it is a
Box
,rayon
needs it collected first so then just recursively calling theapply_rewrite
function seems to not be that bad.