Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable privilege check for system catalogs #20056

Merged
merged 12 commits into from
Feb 20, 2025
Merged

feat: enable privilege check for system catalogs #20056

merged 12 commits into from
Feb 20, 2025
+720 −448

Conversation

yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented Jan 7, 2025 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Resolve #19722 .
Resolve #12047 .

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@yezizp2012 yezizp2012 marked this pull request as ready for review February 19, 2025 09:06
shanicky
shanicky approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@shanicky shanicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yezizp2012 yezizp2012 added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit 9055451 Feb 20, 2025
30 of 31 checks passed
@yezizp2012 yezizp2012 deleted the feat/enable-sys-catalog-privilege branch February 20, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanicky shanicky shanicky approved these changes

@hzxa21 hzxa21 Awaiting requested review from hzxa21

@st1page st1page Awaiting requested review from st1page

Assignees
No one assigned
Labels
type/feature
Projects
None yet
Milestone
No milestone
2 participants
@yezizp2012 @shanicky