Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stream): namespace metrics for unaligned join logstore #20375

Open
wants to merge 76 commits into
base: main
Choose a base branch
from
Open

feat(stream): namespace metrics for unaligned join logstore #20375

wants to merge 76 commits into from
+1,186 −126

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Feb 4, 2025 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?'

Separate metrics from connector metrics

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@kwannoel kwannoel mentioned this pull request Feb 4, 2025
Merged
10 tasks
@kwannoel Graphite App
Copy link
Contributor Author

kwannoel commented Feb 4, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Feb 4, 2025
Draft
Open
@kwannoel kwannoel changed the title refactor constructor feat(stream): add dedicated metrics for unaligned join logstore Feb 4, 2025
@kwannoel kwannoel mentioned this pull request Feb 5, 2025
Open
8 tasks
@kwannoel kwannoel force-pushed the kwannoel/metrics-2 branch 7 times, most recently from dfc81a7 to aa8bfa2 Compare February 6, 2025 09:05
@kwannoel kwannoel requested review from wenym1 and chenzl25 February 6, 2025 10:40
@kwannoel kwannoel marked this pull request as ready for review February 6, 2025 10:40
@kwannoel kwannoel changed the title feat(stream): add dedicated metrics for unaligned join logstore feat(stream): namespace metrics for unaligned join logstore Feb 6, 2025
@kwannoel kwannoel force-pushed the 01-06-feat_stream_add_synced_logstores branch from 1c4dd36 to 9f70496 Compare February 6, 2025 12:20
@kwannoel kwannoel requested a review from a team as a code owner February 6, 2025 12:20
@kwannoel kwannoel requested review from stdrc and removed request for a team February 6, 2025 12:20
@kwannoel kwannoel force-pushed the kwannoel/metrics-2 branch 2 times, most recently from 131ae45 to b8103b9 Compare February 6, 2025 12:32
kwannoel and others added 27 commits February 7, 2025 13:25
@kwannoel
use expect_first_barrier + yield before init state store
4c619ce
@kwannoel
fix warn
0e343bc
@kwannoel
apply vnode update to write path
69b3fc8
@kwannoel
update read path
e512989
@kwannoel
no need lock
63a375d
@kwannoel
fix test
61a8b30
@kwannoel
need to handle watermark
e6e2092
@kwannoel
Apply suggestions from code review
a7bf527
@kwannoel
no need read_metrics
5862b88
@kwannoel
fix vis
43d94bd
@kwannoel
remove unnecessary read metrics from test
5457a54
@kwannoel
remove unnecessary fields
74ea90a
@kwannoel
just pass epoch
49b0aef
@kwannoel
UpdateVnodes should not be in buffer
4ff702d
@kwannoel
fix test
c4b9c1a
@kwannoel
move vnode bitmap updates to top level
ffee918
@kwannoel
fmt + fix async -> sync
06ce11a
@kwannoel
await
3eb0ecc
@kwannoel
fix control flow
3c68523
@kwannoel
fmt
6c72967
@kwannoel
increase timeout
3559fa2
@kwannoel
return pending if no results from the logstore side
eed0d41
@kwannoel
fix compat
1d8ef0f
@kwannoel
increase timeout
7eb5c8a
@kwannoel
refactor constructor
688d5ad
@kwannoel
rename connector -> upstream
db2b4bb
@kwannoel
rename to target
fc4c5b3
@kwannoel kwannoel force-pushed the 01-06-feat_stream_add_synced_logstores branch from cb518dd to 7eb5c8a Compare February 7, 2025 05:26
Base automatically changed from 01-06-feat_stream_add_synced_logstores to main February 7, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenym1 wenym1 Awaiting requested review from wenym1

@chenzl25 chenzl25 Awaiting requested review from chenzl25

@stdrc stdrc Awaiting requested review from stdrc stdrc is a code owner automatically assigned from risingwavelabs/cargo-lock

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
type/feature type/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kwannoel