feat(cdc): fix generated column for table on cdc source #20380
+122
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeXiangWang
force-pushed
the
wkx/generated-column-for-table-on-cdc-source
branch
from
f532f61 to
573a50b
Compare
Can you please fix the bug before merging or recognize the unsupported case and return to user a readable error message? I don't think it's acceptable to merge a new feature with a known panic bug in it... |
st1page
approved these changes
Feb 5, 2025
Comment on lines
+87
to
+90
| println!( | ||
| "WKXLOG after validate cdc source properties, request: {:?}", | ||
| validate_source_request | ||
| ); |
There was a problem hiding this comment.
Suggested change
| println!( | |
| "WKXLOG after validate cdc source properties, request: {:?}", | |
| validate_source_request | |
| ); |
should be removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Resolve #19112 (comment), with a bug/limitation #20356 left.
Checklist
Documentation
Release note