Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make actor graph builder fragment aware #20385

Merged
merged 8 commits into from
Feb 7, 2025

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Feb 5, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously, when we handle ddls that mutate the streaming graph, we store the all dispatcher and merge update in a single vec or map. In this PR, we change to store and pass these information in per-fragment granularity, so that we can get finer-grained information when we handle these updates.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@wenym1 wenym1 force-pushed the yiming/merge-node-no-upstream-actors branch from 8a9dab5 to fc55c3f Compare February 5, 2025 08:55
@wenym1 wenym1 force-pushed the yiming/fragment-aware-actor-graph-builder branch from 7bb1af8 to 8114711 Compare February 5, 2025 08:56
Base automatically changed from yiming/merge-node-no-upstream-actors to main February 5, 2025 11:44
@wenym1 wenym1 force-pushed the yiming/fragment-aware-actor-graph-builder branch from 8114711 to 74762a6 Compare February 6, 2025 04:54
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/meta/src/stream/stream_graph/actor.rs Outdated Show resolved Hide resolved
@wenym1 wenym1 force-pushed the yiming/fragment-aware-actor-graph-builder branch from b98e222 to 9c7d971 Compare February 7, 2025 06:47
@wenym1 wenym1 added this pull request to the merge queue Feb 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 7, 2025
@wenym1 wenym1 added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit 7c7e0ad Feb 7, 2025
31 of 32 checks passed
@wenym1 wenym1 deleted the yiming/fragment-aware-actor-graph-builder branch February 7, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants