Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(udf): introduce async JavaScript UDF #20403

Open
wants to merge 3 commits into
base: eric/js_function_def
Choose a base branch
from

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Feb 6, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR adds support for async JavaScript UDF #20391.

My initial target is to support async function for scalar functions, although the user-defined aggregate functions were also added, we won't document it.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@fuyufjh fuyufjh requested a review from a team as a code owner February 6, 2025 08:54
@fuyufjh fuyufjh requested review from xiangjinwu and removed request for a team February 6, 2025 08:54
@@ -164,7 +164,7 @@ iceberg-catalog-glue = { git = "https://github.com/risingwavelabs/iceberg-rust.g
opendal = "0.49"
# used only by arrow-udf-flight
arrow-flight = "53"
arrow-udf-js = "0.5"
arrow-udf-js = { git = "https://github.com/arrow-udf/arrow-udf.git", rev = "4562678944210da2b3a094a6383f7b9ebe6cc54c" }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for the release of arrow-udf-js before this PR merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant