Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dal-sink): support dynamic json handle mode #20418

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

KeXiangWang
Copy link
Contributor

@KeXiangWang KeXiangWang commented Feb 7, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As titled.
Example:

CREATE sink test_sink as select id, name from test WITH (
    connector = 's3',
) FORMAT PLAIN ENCODE JSON(
    force_append_only='true', 
    jsonb.handling.mode = 'dynamic'
);

With dynamic, jsonb column will be expressed as json object instead string in the files on s3.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Copy link
Contributor

@wcy-fdu wcy-fdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tabVersion
Copy link
Contributor

maybe adding some tests? and need some notes about the expected behavior.

@KeXiangWang
Copy link
Contributor Author

need some notes about the expected behavior.

Added.

maybe adding some tests?

I tried. But we don't have existing tests for s3 sink with JSON format for now... Maybe leave it to a independent PR.

@KeXiangWang KeXiangWang added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 2b269bd Feb 12, 2025
33 of 34 checks passed
@KeXiangWang KeXiangWang deleted the wkx/dal-sink-dynamic-jsonb branch February 12, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants