refactor(types): assign name f{} to unnamed fields of struct (record)
#20490
+101
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 14, 2025
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
changed the title
f{} to unnamed fields of structf{} to unnamed fields of struct (record)
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
kwannoel
approved these changes
Feb 17, 2025
|
nice |
xxchan
reviewed
Feb 19, 2025
| └─BatchScan { table: t, columns: [t.v1, t.v2, t.v3], scan_ranges: [(t.v1, t.v2) >= (Int32(1), Int32(2))], distribution: UpstreamHashShard(t.v1, t.v2, t.v3) } | ||
| - sql: | | ||
| create table t1(v1 int, v2 int, v3 int); | ||
| create materialized view mv1 as select * from t1 order by v1 asc, v2 asc, v3 desc; | ||
| select * from mv1 where (v1,v2,v3) > (1,3,1); | ||
| batch_plan: |- | ||
| BatchExchange { order: [], dist: Single } | ||
| └─BatchFilter { predicate: (Row(mv1.v1, mv1.v2, mv1.v3) > '(1,3,1)':Struct(StructType { field_names: [], field_types: [Int32, Int32, Int32] })) } | ||
| └─BatchFilter { predicate: (Row(mv1.v1, mv1.v2, mv1.v3) > '(1,3,1)':Struct(StructType { fields: [("f1", Int32), ("f2", Int32), ("f3", Int32)] })) } |
There was a problem hiding this comment.
maybe we could further simplify Struct(StructType to just Struct?
xxchan
reviewed
Feb 19, 2025
xxchan
reviewed
Feb 19, 2025
xiangjinwu
approved these changes
Feb 19, 2025
Signed-off-by: Bugen Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
In Postgres,
recordtype (typically created byROWexpression) have fields implicitly namedf1f2etc. This PR makes our implementation more consistent with theirs.Checklist
Documentation
Release note