Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move source retry inside reader stream #20526

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

tabVersion
Copy link
Contributor

@tabVersion tabVersion commented Feb 18, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

replacement of #20295

the intuition is to handle the crash loop when upstream is unavailable and now we only report error when the exec is first executed.

Source backfill does not need to change because when it is doing backfilling, a recover will lead to cancel the job, instead of rebuilding the actor. So when upstream is unavailable, it does not panic RisingWave in recovery.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@tabVersion tabVersion marked this pull request as ready for review February 19, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant