Use new R palette functions to get colours #184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bisaloo
commented
Jan 31, 2020
| @@ -101,7 +101,7 @@ explorespec <- function(rspecdata, by = NULL, | |||
| arg$x <- wl | |||
|
|
|||
| if (is.null(arg$col)) { | |||
| col_list <- viridisLite::viridis(max(table(by))) | |||
| col_list <- palette.colors(n = 8, palette = "Okabe-Ito", alpha = 1) | |||
There was a problem hiding this comment.
Review note (so that I remember): there's no point setting n to more than 8 since the palette only has 8 colours. On the other hand, it doesn't hurt to set it as high as 8.
|
Relevant information is stored in #196. No need to keep this PR open since it might not happen before a very long time. The diffs are still stored by GitHub if we want to make the switch at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R (>=3.6.0)R (>=4.0.0)so, just a draft PR for now.