Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove hoe #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: remove hoe #23

wants to merge 1 commit into from

Conversation

doudou
Copy link
Member

@doudou doudou commented Dec 11, 2024

No description provided.

@pierrewillenbrockdfki
Copy link

I got this in a workspace that never had the current version of the bundle installed before, on ubuntu 22.04, with master branch of tools/syskit, tools/roby and base/scripts:

    rake aborted!
    LoadError: cannot load such file -- rock/bundle
    /home/pierre/ric-backbone/tools/roby/lib/roby/custom_require.rb:50:in `require'
    /home/pierre/ric-backbone/tools/roby/lib/roby/custom_require.rb:50:in `require'
    /home/pierre/ric-backbone/base/scripts/lib/rock/roby_plugin.rb:1:in `<top (required)>'
    /home/pierre/ric-backbone/tools/roby/lib/roby/app.rb:1842:in `require'
    /home/pierre/ric-backbone/tools/roby/lib/roby/app.rb:1842:in `block in require'
    /home/pierre/ric-backbone/tools/roby/lib/roby/app.rb:1821:in `isolate_load_errors'
    /home/pierre/ric-backbone/tools/roby/lib/roby/app.rb:1838:in `require'
    /home/pierre/ric-backbone/tools/roby/lib/roby/app.rb:1324:in `load_plugin_file'
    /home/pierre/ric-backbone/tools/roby/lib/roby/app.rb:1391:in `block in register_plugins'
    /home/pierre/ric-backbone/tools/roby/lib/roby/app.rb:1387:in `each'
    /home/pierre/ric-backbone/tools/roby/lib/roby/app.rb:1387:in `register_plugins'
    /home/pierre/ric-backbone/tools/roby/lib/roby/app.rb:966:in `load_base_config'
    /home/pierre/ric-backbone/bundles/rock/Rakefile:9:in `<top (required)>'
    /home/pierre/.local/share/autoproj/gems/ruby/3.0.0/gems/rake-13.2.1/exe/rake:27:in `<top (required)>'

This works fine in irb, though:

require "roby/app/rake"
Roby.app.load_base_config

Not sure how to resolve this, i guess bundler is interfering?

@doudou
Copy link
Member Author

doudou commented Dec 19, 2024

I got this in a workspace that never had the current version of the bundle installed before, on ubuntu 22.04, with master branch of tools/syskit, tools/roby and base/scripts:

    rake aborted!
    LoadError: cannot load such file -- rock/bundle
    /home/pierre/ric-backbone/tools/roby/lib/roby/custom_require.rb:50:in `require'
    /home/pierre/ric-backbone/tools/roby/lib/roby/custom_require.rb:50:in `require'
    /home/pierre/ric-backbone/base/scripts/lib/rock/roby_plugin.rb:1:in `<top (required)>'
    /home/pierre/ric-backbone/tools/roby/lib/roby/app.rb:1842:in `require'
    /home/pierre/ric-backbone/tools/roby/lib/roby/app.rb:1842:in `block in require'
    /home/pierre/ric-backbone/tools/roby/lib/roby/app.rb:1821:in `isolate_load_errors'
    /home/pierre/ric-backbone/tools/roby/lib/roby/app.rb:1838:in `require'
    /home/pierre/ric-backbone/tools/roby/lib/roby/app.rb:1324:in `load_plugin_file'
    /home/pierre/ric-backbone/tools/roby/lib/roby/app.rb:1391:in `block in register_plugins'
    /home/pierre/ric-backbone/tools/roby/lib/roby/app.rb:1387:in `each'
    /home/pierre/ric-backbone/tools/roby/lib/roby/app.rb:1387:in `register_plugins'
    /home/pierre/ric-backbone/tools/roby/lib/roby/app.rb:966:in `load_base_config'
    /home/pierre/ric-backbone/bundles/rock/Rakefile:9:in `<top (required)>'
    /home/pierre/.local/share/autoproj/gems/ruby/3.0.0/gems/rake-13.2.1/exe/rake:27:in `<top (required)>'

This works fine in irb, though:

require "roby/app/rake"
Roby.app.load_base_config

Not sure how to resolve this, i guess bundler is interfering?

I think an issue with the missing dependency of bundles/rock on base/scripts. If you add it, please make it optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants