fix: improve async #160
Open
fix: improve async #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces of an async task
wvmcastro
approved these changes
Dec 16, 2024
…te operation `reachable?` does `valid_delegator?` and then calls `ping` to check if the task is actually alive. But (1) it requires a round-trip before actually accessing the remote, and (2) is an illusion since the task could disappear between reachable? and the actual remote operation.
doudou
force-pushed
the
improve-async
branch
from
a006750 to
13dcb35
Compare
to_s calls type to form the string, but type tries to embed #{self} in
the error message if not connected.
jhonasiv
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tools and improvements meant to improve responsiveness/usefulness of async over less-than-perfect connections.