Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script: add more postchecks #67

Merged
merged 32 commits into from
Aug 26, 2024
Merged

Conversation

TuDo1403
Copy link
Collaborator

@TuDo1403 TuDo1403 commented Aug 19, 2024

Description

This PR adds new post checks:

  • Proposal:
    • [BridgeManager]: fails if non-governor vote on proposal
    • [BridgeManager]: fails if non-governor create proposal
    • [BridgeManager]: fails if insufficient signature when relay proposal
  • Quorum Config:
    • [BridgeManager] total weight >= 300.
    • [BridgeManager] require valid thresholds.
    • [BridgeManager] operator weight must be strictly 100 for both chains.
    • [Gateway] minimum vote weight != 0.
    • [Gateway] require valid thresholds.
  • Deposit/Withdraw:
    • [Gateway]: WETH address unchanged on ethereum.
    • [Gateway]: Deposit ETH on Ethereum.
    • [Gateway]: Deposit WETH on Ethereum.
    • [Gateway]: Deposit ETH fails if sent insuficient value compared to info.quantity.
    • [Gateway]: Withdraw ERC20 fails if the number of signature is less than the threshold.
    • [Gateway]: Deposit ERC20 fails if the number of signature is less than the threshold.
    • [Gateway]: Withdraw ERC20 fails if submitted duplicated signatures.
    • [Gateway]: Withdraw ERC20 fails if submitted unsorted signatures.

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@TuDo1403 TuDo1403 changed the title Script/add more postchecks script: add more postchecks Aug 19, 2024
@TuDo1403 TuDo1403 force-pushed the script/add-more-postchecks branch 3 times, most recently from b617536 to e4b64f7 Compare August 22, 2024 17:30
@TuDo1403 TuDo1403 force-pushed the script/add-more-postchecks branch from f614551 to 67cf7cf Compare August 23, 2024 08:47
@nxqbao
Copy link
Contributor

nxqbao commented Aug 26, 2024

LGTM

@TuDo1403 TuDo1403 merged commit aeb52c4 into release/v3.2.4 Aug 26, 2024
1 of 3 checks passed
@TuDo1403 TuDo1403 deleted the script/add-more-postchecks branch August 26, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants