-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Add Azure CI file and fixing test breaks on Windows #661
base: master
Are you sure you want to change the base?
[Windows] Add Azure CI file and fixing test breaks on Windows #661
Conversation
Azure CI result is published here: https://ros-win.visualstudio.com/ros-win/_build/results?buildId=3150 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #661 +/- ##
==========================================
+ Coverage 75.99% 76.51% +0.51%
==========================================
Files 40 41 +1
Lines 3129 3330 +201
==========================================
+ Hits 2378 2548 +170
- Misses 751 782 +31 ☔ View full report in Codecov by Sentry. |
@nuclearsandwich Just a friendly ping. This is a PR focused on fixing test failures for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good to me. Though I saw that there were some places to reduce the size of the diff/additional code for better long term maintenance.
I'm a little surprised that the sudo commands were necessary to adjust for windows as in the unit tests I expect them to not be executed and just be string matching, but I think this is an improvement so we might as well use it.
985b6f6
to
4b15bc3
Compare
@tfoote @nuclearsandwich I pushed new changes to address the duplicate logic feedbacks and rebase the code to the latest master. And the results are green for Windows CI: https://ros-win.visualstudio.com/ros-win/_build/results?buildId=4336 Hope you can take a look for the new iteration! Thanks! |
6be5f9e
to
6c2072e
Compare
@cottsay @tfoote @nuclearsandwich Please excuse me to ping you all. Hope this is still under the radar and it would be nice to see more Windows support for |
|
This change is to add Azure DevOps pipelines for running Windows CI, and also fixes test breaks on Windows:
Highlight the changes on the production code side:
src/rosdep2/platforms/source.py
src/rosdep2/shell_utils.py
.bat
on Windows to make the shell able to run the script.src/rosdep2/main.py
os.EX_USAGE
on Windows causing runtime errors.os.pathsep
to replace:
src/rosdep2/platforms/windows.py
&src/rosdep2/__init__.py
rosdep2.platforms.windows
to avoidUnsupported OS
error on Windows.src/rosdep2/installers.py
os.geteuid()
.Summary of changes on the test code side:
sudo -H
changes.file://
URIs in test cases.test_RosdepInstaller_install_resolved
os.path.samefile
for Python 2 on Windows.