Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new repository for indexing: laser_segmentation, sicks300_2, slg_msg in jazzy #44462

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ajtudela
Copy link
Contributor

Please Add This Package to be indexed in the rosdistro.

jazzy

The source is here:

https://github.com/ajtudela/laser_segmentation
https://github.com/ajtudela/sicks300_ros2
https://github.com/ajtudela/slg_msgs

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

@ajtudela ajtudela requested a review from Yadunund as a code owner February 13, 2025 07:44
@github-actions github-actions bot added humble Issue/PR is for the ROS 2 Humble distribution jazzy Issue/PR is for the ROS 2 Jazzy distribution rolling Issue/PR is for the ROS 2 Rolling distribution labels Feb 13, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@ajtudela
Copy link
Contributor Author

Jazzy branch for one of the repos is fixed now

@sloretz sloretz added the held for sync Issue/PR has been held because the distribution is in a sync hold label Feb 13, 2025
@sloretz
Copy link
Contributor

sloretz commented Feb 13, 2025

Holding for Humble sync

jazzy/distribution.yaml Show resolved Hide resolved
sicks300_ros2:
doc:
type: git
url: https://github.com/ajtudela/sicks300_ros2.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put the comment on the wrong line. This is the one CI is failing at:

ERROR: In file '''/home/runner/work/rosdistro/rosdistro/jazzy/distribution.yaml''': Could not validate doc entry for repo sicks300_ros2 with error [[[Could not validate repository with url https://github.com/ajtudela/sicks300_ros2.git and version jazzy from entry at line 8568. Error reason: No branch found matching jazzy]]]
F

https://github.com/ros/rosdistro/actions/runs/13302799815/job/37147175228?pr=44462

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try re-triggering CI then

@audrow audrow removed the held for sync Issue/PR has been held because the distribution is in a sync hold label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
humble Issue/PR is for the ROS 2 Humble distribution jazzy Issue/PR is for the ROS 2 Jazzy distribution rolling Issue/PR is for the ROS 2 Rolling distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants