Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synapticon_ros2_control: 0.1.1-2 in 'humble/distribution.yaml' [bloom] #44468

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zvezdan94
Copy link

Increasing version of package(s) in repository synapticon_ros2_control to 0.1.1-2:

@github-actions github-actions bot added the humble Issue/PR is for the ROS 2 Humble distribution label Feb 13, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@sloretz sloretz added the held for sync Issue/PR has been held because the distribution is in a sync hold label Feb 13, 2025
@sloretz
Copy link
Contributor

sloretz commented Feb 13, 2025

Holding for Humble sync

@audrow audrow removed the held for sync Issue/PR has been held because the distribution is in a sync hold label Feb 14, 2025
@MichaelOrlov
Copy link
Collaborator

@zvezdan94 The source repository referenced in this PR https://github.com/synapticon/synapticon_ros2_control is a fork of the https://github.com/elevaterobotics/synapticon_ros2_control.

I am curious why the fork was made, and what efforts have been made to contact the upstream. according to the rules https://github.com/ros/rosdistro/blob/master/REVIEW_GUIDELINES.md. The submitter should have at least opened an issue on the upstream asking for a release, and then waited for a response at least for a 4 weeks.

@MichaelOrlov MichaelOrlov self-requested a review February 15, 2025 02:55
@MichaelOrlov MichaelOrlov added the more information needed Maintainers have asked for additional information label Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
humble Issue/PR is for the ROS 2 Humble distribution more information needed Maintainers have asked for additional information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants