Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rmw: 7.7.0-1 in 'rolling/distribution.yaml' [bloom] #44482

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Feb 14, 2025

Increasing version of package(s) in repository rmw to 7.7.0-1:

rmw

* get_zero_initialized_xxx functions return zero initialized structure. (#380 <https://github.com/ros2/rmw/issues/380>)
  * get_zero_initialized_xxx functions return zero initialized structure.
  * introduce RMW_EVENT_TYPE_MAX in rmw_event_type_t.
  * add a comment and more tests for rmw_event_type.
  ---------
* Contributors: Tomoya Fujita

rmw_implementation_cmake

  • No changes

rmw_security_common

* Added rmw_security_common (#388 <https://github.com/ros2/rmw/issues/388>)
* Contributors: Alejandro Hernández Cordero

@ahcorde ahcorde requested a review from Yadunund as a code owner February 14, 2025 09:27
@github-actions github-actions bot added the rolling Issue/PR is for the ROS 2 Rolling distribution label Feb 14, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahcorde I would have expected to see a major version bump given that we added a new package. Let's align on how we bump versions of core packages for Rolling in the next PMC meeting!

@MichaelOrlov
Copy link
Collaborator

  • In general, I would agree with @Yadunund about major version bump when adding a new package.
    However, we usually bump major versions when making API/ABI-breaking changes. Adding a new package and a new API usually does not break API/ABI compatibility.
  • Therefore merging this PR as is.

@MichaelOrlov MichaelOrlov merged commit 31e9b7b into ros:master Feb 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rolling Issue/PR is for the ROS 2 Rolling distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants